Thread (30 messages) 30 messages, 6 authors, 2023-08-28

Re: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2023-08-21 10:32:49
Also in: lkml

On Mon, Aug 21, 2023 at 12:19:39PM +0200, Benjamin Tissoires wrote:
On Mon, Aug 21, 2023 at 11:35 AM Andy Shevchenko
[off-list ref] wrote:
quoted
On Mon, Aug 21, 2023 at 12:34:30PM +0300, Andy Shevchenko wrote:
quoted
On Mon, Aug 21, 2023 at 10:51:04AM +0200, Benjamin Tissoires wrote:
quoted
On Aug 21 2023, Andy Shevchenko wrote:
...
quoted
quoted
quoted
Long story short, I'm not able to test it right now (and I got quite
some backlog as you can imagine). IIRC the code was fine, so I think we
can just take the series as is, and work on the quirks (if any) later.
Thank you!

The thing that might be broken is interrupts handling. If that works,
I'm pretty confident with the rest.
I.o.w. first 5 patches to test is already 98% of guarantee that everything
is fine.
Actually I applied you series locally, and applied Danny's patches on
top, and I could run your series in qemu with the cp2112 as USB
passthrough.

Everything is working fine, so I can take this one just now.
Thank you! I assume you have some IRQ (like GPIO button) to test with that.
If no, it's easily to describe (in ACPI, see [1]) and use a wire to emulate
the button presses. In that case the /proc/interrupts should show the
different numbers.

[1]: https://github.com/westeri/meta-acpi/blob/master/recipes-bsp/acpi-tables/samples/edison/buttons.asli

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help