Re: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings
From: Jiri Kosina <jikos@kernel.org>
Date: 2023-08-14 09:29:43
Also in:
lkml
From: Jiri Kosina <jikos@kernel.org>
Date: 2023-08-14 09:29:43
Also in:
lkml
On Mon, 7 Aug 2023, Andy Shevchenko wrote:
quoted
quoted
quoted
quoted
After I updated GPIO library for the case Benjamin has with CP2112, I have a brief look into the CP2112 driver itself. From GPIO perspective it has two main (maitenance) issues: - usage of ->to_irq() with IRQ chip present; - having IRQ chip not immutable. Besides that there are plenty small cleanups here and there. Hence this series.Any comments on this?Gentle ping^2 for this... Anything should I do to improve it or is it okay to go as is?I have been off pretty much the whole July. I am now back and slowly making my way through everything that accumulated, I will eventually get to this. Thanks for the patience,Ah, okay, no worries and take your time! I was thinking more on Benjamin's answer as last time he had a hw setup to test... Not sure what the status of that now and if he has a chance to test this or busy enough with something else.
Ah, that would be of course nice. Benjamin? Thanks, -- Jiri Kosina SUSE Labs