On Fri, Jul 8, 2022 at 5:05 PM Sa, Nuno [off-list ref] wrote:

quoted

From: Andy Shevchenko <redacted>
Sent: Friday, July 8, 2022 4:50 PM
On Fri, Jul 8, 2022 at 11:36 AM Nuno Sá [off-list ref] wrote:

...

quoted

quoted

-#define ADP5588_KE_IEN         (1 << 0)

quoted

+#define ADP5588_KE_IEN         BIT(0)

This is actually a change. And if there wasn't bits.h included, you
would do it as well.

You mean because of it being unsigned now? Well, I guess it's true
but in practice I don't think it will have any side effect..

int --> unsigned long

FYI: We used to have bugs with this conversation in the past.

So, please amend the commit message accordingly. And as I mentioned,
this should probably be done before the rest of this patch.

-- 
With Best Regards,
Andy Shevchenko