-----Original Message-----
From: Andy Shevchenko <redacted>
Sent: Friday, July 8, 2022 4:25 PM
To: Sa, Nuno <Nuno.Sa@analog.com>
Cc: devicetree <redacted>; open list:GPIO
SUBSYSTEM [off-list ref]; linux-input <linux-
input@vger.kernel.org>; Dmitry Torokhov
[off-list ref]; Bartosz Golaszewski
[off-list ref]; Hennerich, Michael
[off-list ref]; Rob Herring
[off-list ref]; Krzysztof Kozlowski
[off-list ref]; Linus Walleij
[off-list ref]
Subject: Re: [PATCH 03/10] input: keyboard: adp5588-keys: bail out on
returned error

[External]

On Fri, Jul 8, 2022 at 11:36 AM Nuno Sá [off-list ref] wrote:

quoted

Don't continue in code paths after some error is found. It makes no
sense to do any other device configuration if a previous one failed.

...

quoted

                for (i = 0; i <= ADP5588_BANK(ADP5588_MAXGPIO); i++) {
                        int pull_mask = gpio_data->pullup_dis_mask;

-                       ret |= adp5588_write(client, GPIO_PULL1 + i,
+                       ret = adp5588_write(client, GPIO_PULL1 + i,
                                (pull_mask >> (8 * i)) & 0xFF);
+                       if (ret)
+                               return ret;
                }

Looks like a good candidate for bitmap_get_value8(pull_mask).

I'm not touching the original way the driver was handling this
kind of stuff. I do have in my mind to just convert this driver to use
regmap and with it (by using the *bits functions) we can get rid of
most of the "plain" bitmaps in the driver.

- Nuno Sá