Re: [PATCH 04/10] input: keyboard: adp5588-keys: add support for fw properties

On Fri, Jul 8, 2022 at 5:04 PM Sa, Nuno [off-list ref] wrote:

quoted

From: Andy Shevchenko <redacted>
Sent: Friday, July 8, 2022 4:56 PM
On Fri, Jul 8, 2022 at 11:37 AM Nuno Sá [off-list ref] wrote:

...

quoted

Okay, you add something in the wrong form and then fix it in the other
patch in the very same series? Please no ping-pong type of changes.
Squash / rebase your series accordingly.

Well, I thought to just copy it as it was on the platform file and then just fix
it with the rest of the coding styles changes. But I'm fine in fixing it already
in this patch. In fact, there's a lot of defines that are not used (it's just
defining the complete register map) so I can as well get rid of all the stuff
that is not used anywhere in the driver.

This needs to be split to:

1) fix existing
2) move data
3) use that data

Or

1) move data (no other changes, if possible)
2) fix data
3) use it

...

quoted

quoted

+       ret = adp5588_write(client, KP_GPIO2, KP_SEL(kpad->cols) &

0xFF);

Do you need these " & 0xFF" parts?

Not sure but probably not. I just kept as it was...

It's rather for a separate change.

-- 
With Best Regards,
Andy Shevchenko