Thread (26 messages) 26 messages, 3 authors, 2018-02-01

Re: [PATCH 5/8] Input: mms114 - use lower case for hexadecimal values

From: Andi Shyti <hidden>
Date: 2018-01-29 23:29:29
Also in: lkml

Hi Dmitry,

On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote:
On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote:
quoted
Signed-off-by: Andi Shyti <redacted>
But why?
I think this patch is trivial and the subject itself is quite
self-explanatory and the commit message would be a copy-paste of
it.

OK, if you want I will add "some comment".

Andi
quoted
---
 drivers/input/touchscreen/mms114.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
index 11dba8bb48e3..fdf23bc416af 100644
--- a/drivers/input/touchscreen/mms114.c
+++ b/drivers/input/touchscreen/mms114.c
@@ -20,7 +20,7 @@
 
 /* Write only registers */
 #define MMS114_MODE_CONTROL		0x01
-#define MMS114_OPERATION_MODE_MASK	0xE
+#define MMS114_OPERATION_MODE_MASK	0xe
 #define MMS114_ACTIVE			(1 << 1)
 
 #define MMS114_XY_RESOLUTION_H		0x02
@@ -30,12 +30,12 @@
 #define MMS114_MOVING_THRESHOLD		0x06
 
 /* Read only registers */
-#define MMS114_PACKET_SIZE		0x0F
+#define MMS114_PACKET_SIZE		0x0f
 #define MMS114_INFOMATION		0x10
-#define MMS114_TSP_REV			0xF0
+#define MMS114_TSP_REV			0xf0
 
-#define MMS152_FW_REV			0xE1
-#define MMS152_COMPAT_GROUP		0xF2
+#define MMS152_FW_REV			0xe1
+#define MMS152_COMPAT_GROUP		0xf2
 
 /* 200ms needs after power on */
 #define MMS114_POWERON_DELAY		200
-- 
2.15.1
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help