Thread (26 messages) flat view 26 messages, 3 authors, 2018-02-01

Re: [PATCH 4/8] Input: mms114 - remove unused variable

From: Andi Shyti <hidden>
Date: 2018-01-29 23:27:57
Also in: lkml

Hi Dmitry,

On Mon, Jan 29, 2018 at 10:43:09AM -0800, Dmitry Torokhov wrote:
On Mon, Jan 29, 2018 at 08:33:19PM +0900, Andi Shyti wrote:
quoted
'__packed' is not used anywhere, remove it.
Umm, this is not a variable, this is type annotation meaning that the
structure is packed. Still not needed, as we are not using anything but
u8 data elements, but justification is completely wrong.
Oh dammit! :)

of course! The original idea was the alignment of the structure,
but I must have got confused while re-editing all the commits.

Sorry, I'll fix it.

Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help