Re: [PATCH 4/8] Input: mms114 - remove unused variable
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2018-01-29 18:43:18
Also in:
lkml
On Mon, Jan 29, 2018 at 08:33:19PM +0900, Andi Shyti wrote:
'__packed' is not used anywhere, remove it.
Umm, this is not a variable, this is type annotation meaning that the structure is packed. Still not needed, as we are not using anything but u8 data elements, but justification is completely wrong.
quoted hunk ↗ jump to hunk
Signed-off-by: Andi Shyti <redacted> --- drivers/input/touchscreen/mms114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index fb4435ae506b..11dba8bb48e3 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c@@ -78,7 +78,7 @@ struct mms114_touch { u8 width; u8 strength; u8 reserved[2]; -} __packed; +}; static void mms114_process_mt(struct mms114_data *data, struct mms114_touch *touch) {-- 2.15.1
-- Dmitry