Thread (91 messages) 91 messages, 5 authors, 2013-07-11

Re: [PATCH 10/53] Input: atmel_mxt_ts - Add memory access interface via sysfs

From: Mark Brown <broonie@kernel.org>
Date: 2013-07-11 10:31:14
Also in: lkml

On Thu, Jul 11, 2013 at 08:41:41AM +0100, Nick Dyer wrote:
Mark Brown wrote:
quoted
On Fri, Jun 21, 2013 at 09:16:16AM -0700, Nick Dyer wrote:
quoted
quoted
For some operations it does. For example updating the whole chip config
(which is a common thing to want to do), it would turn a couple of write
operations into ~20 on recent chips.
quoted
Is that really happening on peformance critical paths other than initial
power up (which could be handled more neatly anyway).
Well, you're right that we could probably add more API for performance
critical stuff. But that wasn't your original question.
You probably don't need another API here - for example, if the driver
understands that the device is powered off and knows enugh about what
the device is doing to understand that it doesn't need to be running
then it could for example cache what is being written then flush in a
more optimal fashion.
quoted
If absoluely nobody has used the separate wakeup pin then the hardware
designers are wasting a pin there...  my point isn't that nobody would
use the reference design it's that some boards will have the separate
signal.
That's entirely hypothetical, and you're wasting our time until you can
actually point to such hardware, happy to write patches to support that
mode of operation as well if you do.
See above - it's not just about the possibility that someone might have
done a better job with the hardware design, better power management is
just a good idea in general.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help