On Wednesday, June 05, 2013 07:45:04 PM Nick Dyer wrote:

Dmitry Torokhov wrote:

quoted

On Wednesday, June 05, 2013 06:37:03 PM Nick Dyer wrote:

quoted

Atmel maXTouch chips can be addressed via an "Object Based Protocol"
which
defines how i2c registers are mapped to different functions within the
chips. This interface exposes the register map and allows user-space
utilities to inspect and alter object configuration, and to view
diagnostic
data, while the device is running.

I think if the driver was to use regmap then this fucntionality will
already be there as regmap exports registers via debugfs.

Yes, this was suggested in the past and I spent some time looking into it.

We have made a deliberate choice to implement this via sysfs rather than
debugfs since it needs to work on devices that don't have debugfs enabled.

Then they will have to enable it. Re-implementing something because
someone might not enable needed subsystem is not a good idea. Let's
say somebody disabled I2C - will you write your own implementation because
of that? Of course not, you just say that for given functionality it
is a prerequisite.

In addition, there are some quirks about the way in which we have to
read/write registers which means regmap isn't a good fit.

Could you please elaborate more on this?

Thanks.

-- 
Dmitry