Thread (91 messages) flat view 91 messages, 5 authors, 2013-07-11

Re: [PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe

From: Nick Dyer <hidden>
Date: 2013-06-10 09:35:35
Also in: lkml

Yufeng Shen wrote:
quoted
+       dev_info(&client->dev,
+                "Family: %u Variant: %u Firmware V%u.%u.%02X Objects: %u\n",
+                info->family_id, info->variant_id, info->version >> 4,
+                info->version & 0xf, info->build, info->object_num);
+
Use data->info->XXX here,  info was pointing to buf which could have
changed after krealloc.
Thank you, that's a really good spot. Caused when I merged the dev_info
line into that function. It actually explains a report I had about getting
junk in this output but the info_crc check succeeding, hadn't had time to
investigate yet.

I will fix.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help