Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

On Friday 24 August 2012 16:42:20 Yann Cantin wrote:

Hi,

Le 24/08/2012 13:41, Oliver Neukum a écrit :

quoted

On Friday 24 August 2012 11:37:45 Yann Cantin wrote:

quoted

Hi,

Le 23/08/2012 09:23, Oliver Neukum a écrit :

quoted

On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:

quoted

quoted

These functions are identical. You should unify them.

Removed reset_resume from the driver (optional, and not needed
for this hardware).

Why did you do that? It is always better to have reset_resume().
And you cannot tell whether it will be needed.

This function was used in usbtouchscreen (which this driver is based on)
for some hardware specific init after reset. eBeam devices doesn't need that,
and i didn't mention the similarity of the 2 functions after stripping the code.

According to power-management.txt, reset_resume is optional, and lot of input
driver lack it. Anyway, if you think it's worth the code, i'll re-add a 
reset_resume function proxing resume like wacom_sys.c do.

It is always better to have reset_resume() if it can be easily done.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html