Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

Hi,

Le 23/08/2012 08:54, Oliver Neukum a écrit :

On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:

quoted

+       /* input final setup */
+       err = input_register_device(ebeam->input);
+       if (err) {
+               dev_dbg(&intf->dev,
+                       "%s - input_register_device failed, err: %d\n",
+                       __func__, err);
+               goto out_free_urb;
+       }
+
+       ebeam_setup_input(ebeam, input_dev);
+
+       /* usb final setup */
+       usb_set_intfdata(intf, ebeam);

Hi,

this looks like a classic race. You initialize the device after you
register it. However, it may be used at that time.

Ok, moved ebeam_setup_input before input_register_device.

Thanks.

-- 
Yann Cantin
A4FEB47F
--
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html