Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

From
Oliver Neukum <hidden>
Date
2012-08-23 07:18:48
Also in
lkml
Reply to
Yann Cantin, 2012-08-22
On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:
quoted hunk ↗ jump to hunk
+       /* input final setup */
+       err = input_register_device(ebeam->input);
+       if (err) {
+               dev_dbg(&intf->dev,
+                       "%s - input_register_device failed, err: %d\n",
+                       __func__, err);
+               goto out_free_urb;
+       }
+
+       ebeam_setup_input(ebeam, input_dev);
+
+       /* usb final setup */
+       usb_set_intfdata(intf, ebeam);
Hi,

this looks like a classic race. You initialize the device after you
register it. However, it may be used at that time.

	Regards
		Oliver
Thread (10 messages) 10 messages, 2 authors, last reply 2012-09-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help