Thread (26 messages) flat view 26 messages, 3 authors, 2012-08-21

Re: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

From: Felipe Balbi <hidden>
Date: 2012-08-21 12:46:48
Also in: linux-arm-kernel, linux-devicetree, linux-omap, lkml

On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:
quoted
+	regmap_read(smsc->regmap, SMSC_DEV_ID, &ret);
+	dev_dbg(&i2c->dev, "SMSC Device ID: %d\n", ret);
I'd make these log messages dev_info() or something.
dev_info() ? It'lll just make boot noisier for no good reason. Which
user wants to see this during boot up ? That's a debugging feature for
develop IMHO.

-- 
balbi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help