Re: [PATCH 2/4] Input: keypad: Add smsc ece1099 keypad driver

Hi,

On Tue, Aug 21, 2012 at 4:16 PM, Felipe Balbi [off-list ref] wrote:

Hi,

On Tue, Aug 21, 2012 at 04:15:38PM +0530, Sourav Poddar wrote:

quoted

+static struct platform_driver smsc_driver = {
+     .driver = {
+             .name   = "smsc-keypad",
+             .of_match_table = of_match_ptr(smsc_keypad_dt_match),
+             .owner  = THIS_MODULE,
+     },
+     .probe          = smsc_probe,
+     .remove         = smsc_remove,

one extra comment which I forgot. You probably should put your remove on
__devexit and add __devexit_p(smsc_remove) here.

yes, Will do it.

--
balbi