Re: [PATCH 16/19] HID: hid-multitouch: Remove misleading null test
From: Benjamin Tissoires <hidden>
Date: 2012-08-20 13:36:02
Also in:
lkml
Acked-by: Benjamin Tissoires <redacted> On Sun, Aug 12, 2012 at 11:42 PM, Henrik Rydberg [off-list ref] wrote:
quoted hunk ↗ jump to hunk
A null test was left behind during the autoloading work; the test was introduced by 8d179a9e, but was never completely reverted. Reported-by: Dan Carpenter <redacted> Signed-off-by: Henrik Rydberg <redacted> --- drivers/hid/hid-multitouch.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c400d90..b15133c 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c@@ -691,12 +691,10 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id) struct mt_device *td; struct mt_class *mtclass = mt_classes; /* MT_CLS_DEFAULT */ - if (id) { - for (i = 0; mt_classes[i].name ; i++) { - if (id->driver_data == mt_classes[i].name) { - mtclass = &(mt_classes[i]); - break; - } + for (i = 0; mt_classes[i].name ; i++) { + if (id->driver_data == mt_classes[i].name) { + mtclass = &(mt_classes[i]); + break; } } --1.7.11.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html