Re: [RFC] QT1070: change the trigger mode of QT1070

On 5/12/2012 0:08, Dmitry Torokhov wrote:

On Fri, May 11, 2012 at 04:28:22PM +0800, Josh Wu wrote:

quoted

Hello, Dmitry

On 5/7/2012 3:04 PM, Dmitry Torokhov wrote:

quoted

Hi Bo,

On Mon, May 07, 2012 at 10:27:33AM +0800, Bo Shen wrote:

quoted

The default trigger mode of QT1070 is IRQF_TRIGGER_LOW,
Using TRQF_TRIGGER_FALLING to replace IRQF_TRIGGER_LOW | IRQF_ONESHOT.

Why don't you set up IRQ the way you want in board code instead of
implementing workarounds in the driver?

The QT1070 will generate a falling edge interrupt if any valid data
coming. The workaround is only for the boarding that can handle edge
interrupt but cannot distinguish rising and falling.
So I think put this trigger set up code to board code will make
thing more complex.

In the board code it is only a matter of doing irq_set_irq_type(). AT
this time you know exactly how chip is wired and whether it needs level
or edge interupts.

Hi Dmitry,
   Thanks, this API works fine. So, there is no need to change the 
driver code of QT1070.

Thanks.