Thread (15 messages) flat view 15 messages, 4 authors, 2012-05-14

Re: [RFC] QT1070: change the trigger mode of QT1070

From: javier Martin <hidden>
Date: 2012-05-11 09:13:42

Hi all,
let's take a chip which presents a similar issue like the pca953x [1].
This chip has an IRQ line that is meant to be connected to a SoC input
like the qt1070.

The flags that are used for pca953x are: (IRQF_TRIGGER_LOW | IRQF_ONESHOT)

Can't we do the same for qt1070?
And even more important, can you give me an example of an architecture
in mainline which cannot support these irq flags and still be able to
detect a change from high to low in a GPIO as qt1070 requires?

Moreover, if you try a grep for IRQ_TRIGGER_NONE in the kernel tree
you won't find any driver doing this strange thing.

Do you agree at least that we must change IRQ_TRIGGER_NONE flag into a
more sensible choice?

Regards.

[1] http://lxr.linux.no/#linux+v3.3.4/drivers/gpio/gpio-pca953x.c#L495

-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help