Thread (15 messages) flat view 15 messages, 4 authors, 2012-05-14

Re: [RFC] QT1070: change the trigger mode of QT1070

From: Josh Wu <hidden>
Date: 2012-05-11 08:28:51

Hello, Dmitry

On 5/7/2012 3:04 PM, Dmitry Torokhov wrote:
Hi Bo,

On Mon, May 07, 2012 at 10:27:33AM +0800, Bo Shen wrote:
quoted
The default trigger mode of QT1070 is IRQF_TRIGGER_LOW,
Using TRQF_TRIGGER_FALLING to replace IRQF_TRIGGER_LOW | IRQF_ONESHOT.
Why don't you set up IRQ the way you want in board code instead of
implementing workarounds in the driver?
The QT1070 will generate a falling edge interrupt if any valid data 
coming. The workaround is only for the boarding that can handle edge 
interrupt but cannot distinguish rising and falling.
So I think put this trigger set up code to board code will make thing 
more complex.
Thanks.
Best Regards,
Josh Wu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help