Re: [PATCH v4 1/3] Input: gpio_keys.c: Simplify platform_device -> device casting

Hi Dmitry,

On Sat, 18 Jun 2011 03:19:25 -0700
Dmitry Torokhov [off-list ref] wrote:

On Tue, Jun 14, 2011 at 11:08:09AM +0200, David Jander wrote:

quoted

This patch factors out the use of struct platform_device *pdev in most
places.

Why? We are dealing with a platform device so why would we switch to
generic device?

Actually, when I wrote this patch there still was a difference between
the platform bus and the of_platform bus, and this change was necessary. There
also were ifdefs around platform_driver_register and
of_platform_driver_register. Now it seems this has been merged, and I am
not sure it is necessary anymore, but I still think it simplifies the code
quite a bit. Also, why should the driver be bus-dependent, when it doesn't
even need a real "bus" (it talks to an abstract device through another driver,
potentially connected to any bus), besides due to how linux views devices and
drivers.

I also think that we should not be mixing dev_get/set_drvdata() and
<bus>_get/set_drvdata() calls

AFAICS, we are not mixing.... it is dev_*_drvdata() only.

but rather use appropriate bus-specific version to access data on given
layer.

Doesn't that make the driver much too complex? And why would that be
necessary? The driver isn't bus-specific anymore... except for the binding and
probing part.

Best regards,

-- 
David Jander
Protonic Holland.