Thread (35 messages) 35 messages, 7 authors, 2012-03-16

Re: [PATCH v4 1/3] Input: gpio_keys.c: Simplify platform_device -> device casting

flat view

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-06-18 10:19:39

On Tue, Jun 14, 2011 at 11:08:09AM +0200, David Jander wrote:
This patch factors out the use of struct platform_device *pdev in most
places.
Why? We are dealing with a platform device so why would we switch to
generic device?

I also think that we should not be mixing dev_get/set_drvdata() and
<bus>_get/set_drvdata() calls but rather use appropriate bus-specific
version to access data on given layer.

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help