Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-13 11:27:35
Also in:
lkml
On Sat, Dec 11, 2021 at 01:13:52PM +0300, Sergey Shtylyov wrote:
On 10.12.2021 22:35, Sergei Shtylyov wrote:
...
Also, your commit log is wrong in the description of how to handle the result: << Now: ret = platform_get_irq_optional(...); if (ret != -ENXIO) return ret; // respect deferred probe if (ret > 0) ...we get an IRQ...quoted
quoted
The (ret != -ENXIO) check also succeeds on the (positive) IRQ #s, so the following code becomes unreachable. :-/
Indeed, thanks! Should be if (ret < 0 && ret != -ENXIO) -- With Best Regards, Andy Shevchenko