Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ... | linux-ide

[PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
[PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Damien Le Moal <hidden> · 2021-12-11
Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Damien Le Moal <hidden> · 2021-12-17
Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-17
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Hans de Goede <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergei Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergei Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-11
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-11
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-12
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13

Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-09 17:44:01
Also in: lkml

On Thu, Dec 09, 2021 at 08:24:59PM +0300, Sergey Shtylyov wrote:

On 12/9/21 5:59 PM, Andy Shevchenko wrote:

quoted

platform_get_irq() will print a message when it fails.
No need to repeat this.

While at it, drop redundant check for 0 as platform_get_irq() spills
out a big WARN() in such case.

   And? IRQ0 is still returned! :-(

It should not be returned in the first place.

...

quoted

-	if (!irq)
-		return -EINVAL;

   This is prermature -- let's wait till my patch that stops returning IRQ0 from
platform_get_irq() and friends gets merged....

What patch?

Does it fix platform_get_irq_optional()?

-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help