Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt

[PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
[PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Damien Le Moal <hidden> · 2021-12-11
Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Damien Le Moal <hidden> · 2021-12-17
Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-17
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Hans de Goede <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-09
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergei Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergei Shtylyov <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-11
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-10
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Sergey Shtylyov <hidden> · 2021-12-11
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-12
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Damien Le Moal <hidden> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13
Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-12-13

From: Damien Le Moal <hidden>
Date: 2021-12-11 00:05:02
Also in: lkml

On 2021/12/11 4:34, Andy Shevchenko wrote:

On Thu, Dec 09, 2021 at 04:59:37PM +0200, Andy Shevchenko wrote:

quoted

If 64-bit mask attempt fails, the 32-bit will fail by the very same reason.
Don't even try the latter. It's a continuation of the changes that contains,
e.g. dcc02c19cc06 ("sata_sil24: use dma_set_mask_and_coherent").

I understand that some people have nothing besides bikeshedding, but this patch
seems fine to everybody, am I right? Can it be applied (it's independent from
patch 1 anyways)?

Yes, this one seems fine to me. It would be good to get a different review
though (I know hard to get reviews on ata patches...).
I will queue it for 5.17.


-- 
Damien Le Moal
Western Digital Research

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help