Re: [PATCH 0/6] ZAC host-aware device support
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: 2015-08-02 16:11:13
Also in:
linux-scsi
On Fri, 2015-07-31 at 15:02 +0200, Hannes Reinecke wrote:
Hi all, here is a patchset for adding ZAC host-aware device support to libata. Main bits are translations for ZBC IN and ZBC OUT; others are the required plumbing like generating the correct VPD pages. James, do you require a separate patch for adding ZBC IN and ZBC OUT or is it okay to have it queued here?
This really belongs in the ZBC patch set, doesn't it? Why isn't it there. You can't avoid the dependency. If it goes with the ZAC patch set, then the ZBC one depends on ZAC. If it goes properly with ZBC then you need an additional patch adding the ATA translations after the ZBC one. On the whole, I'd prefer the latter so we always have the required consumers of the API. In fact, if I read the dependencies correctly, you need the ZBC patches first, don't you ... otherwise there's nothing to drive host aware ZAC? James James
As usual, reviews and comments are welcome. Hannes Reinecke (6): libata: Do not retry commands with valid autosense libata-scsi: use ata_scsi_set_sense when generating ATA sense libata: implement ZBC IN translation libata: Implement ZBC OUT translation libata: support device-managed ZAC devices libata: support host-aware ZAC devices drivers/ata/libata-core.c | 50 +++++++ drivers/ata/libata-eh.c | 4 + drivers/ata/libata-scsi.c | 299 +++++++++++++++++++++++++++++++++++------- include/linux/ata.h | 17 +++ include/linux/libata.h | 7 + include/scsi/scsi_proto.h | 9 ++ include/trace/events/libata.h | 2 + 7 files changed, 344 insertions(+), 44 deletions(-)