Thread (1 message) 1 message, 1 author, 2014-09-15

Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

From: Tejun Heo <tj@kernel.org>
Date: 2014-09-15 07:44:58
Also in: linux-arm-kernel, linux-devicetree, linux-scsi

Possibly related (same subject, not in this thread)

On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote:
[suman] : So the posted version is acceptable ? Any others comments on this
patch ?
I'm suggesting setting ctx->cs_mux to NULL on failure.  IOW,

	if (res) {
		ctx->csr_mux = devm_ioremap_resources();
		if (IS_ERR(ctx->csr_mux)) {
			print warning or something;
			ctx->csr_mux = NULL;
		}
	}

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help