Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.
From: Tejun Heo <tj@kernel.org>
Date: 2014-09-12 17:50:21
Also in:
linux-arm-kernel, linux-devicetree, linux-scsi
On Fri, Sep 12, 2014 at 01:24:08PM +0530, Suman Tripathi wrote:
quoted hunk ↗ jump to hunk
This patch fixes the error print invalid resource for the APM X-Gene SoC AHCI SATA Host Controller driver. This print was due to the fact that the controller 3 don't have a mux resource. This didn't result in any errors but the print seems like meaningless. Signed-off-by: Loc Ho <redacted> Signed-off-by: Suman Tripathi <redacted> --- drivers/ata/ahci_xgene.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c index 40d0a76..9404db0c 100644 --- a/drivers/ata/ahci_xgene.c +++ b/drivers/ata/ahci_xgene.c@@ -434,7 +434,7 @@ static int xgene_ahci_mux_select(struct xgene_ahci_context *ctx) u32 val; /* Check for optional MUX resource */ - if (IS_ERR(ctx->csr_mux)) + if (!ctx->csr_mux) return 0;
Hmmm? So, if devm_ioremap_resource() call actually fails, now the function tries to operation on ERR_PTR() value as a real pointer? Thanks. -- tejun