Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.
From: Tejun Heo <tj@kernel.org>
Date: 2014-09-14 09:39:11
Also in:
linux-arm-kernel, linux-devicetree, linux-scsi
Possibly related (same subject, not in this thread)
- 2014-09-23 · Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver. · Tejun Heo <tj@kernel.org>
- 2014-09-22 · [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver. · Suman Tripathi <hidden>
- 2014-09-15 · Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver. · Russell King - ARM Linux <hidden>
- 2014-09-15 · Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver. · Tejun Heo <tj@kernel.org>
- 2014-09-12 · Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver. · Tejun Heo <tj@kernel.org>
Hello, On Sun, Sep 14, 2014 at 11:36:51AM +0530, Suman Tripathi wrote:
We can maintain same piece (IS_ERR(ctx->csr_mux)), then we can do the below instead of NULL ?? ctx->csr_mux = res ? devm_ioremap_resource(dev, res) : ERR_PTR(-EINVAL);
Setting it to NULL on failure would probably make more sense. No need to carry around ERR_PTR() value around. Thanks. -- tejun