Re: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag
From: Brian Norris <computersforpeace@gmail.com>
Date: 2012-02-20 22:06:53
Also in:
lkml
On Mon, Feb 20, 2012 at 1:23 PM, Tejun Heo [off-list ref] wrote:
On Mon, Feb 20, 2012 at 01:16:27PM -0800, Brian Norris wrote:quoted
On Mon, Feb 20, 2012 at 12:51 PM, Tejun Heo [off-list ref] wrote:quoted
Overall the patchset looks good but On Mon, Feb 20, 2012 at 12:09:21PM -0800, Brian Norris wrote:quoted
+ AHCI_HFLAG_STRICT_SPEC = (1 << 15), /* strict AHCI spec */can you please use something more specific? e.g. something like SKIP_ENGINE_ON_PORT_START and then explain what the flag is about in the comment?So you want AHCI_HFLAG_SKIP_ENGINE_ON_PORT_START? That seems excessively long... how about AHCI_HFLAG_DELAY_ENGINE? (since it pushes the start engine call back to the error-handling stage)Ooh, yeah, that seems better. I'm fine with any name which ties it to engine behavior on port start.
OK. I'll wait a bit for other comments, then send a v2 series with AHCI_HFLAG_DELAY_ENGINE. Brian