Re: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag

[PATCH 0/3] ahci: fix boot/resume COMRESET failures · Brian Norris <computersforpeace@gmail.com> · 2012-02-20
[PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag · Brian Norris <computersforpeace@gmail.com> · 2012-02-20
Re: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag · Tejun Heo <tj@kernel.org> · 2012-02-20
Re: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag · Brian Norris <computersforpeace@gmail.com> · 2012-02-20
Re: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag · Tejun Heo <tj@kernel.org> · 2012-02-20
Re: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag · Brian Norris <computersforpeace@gmail.com> · 2012-02-20
[PATCH 2/3] ahci: move AHCI_HFLAGS() macro to ahci.h · Brian Norris <computersforpeace@gmail.com> · 2012-02-20
[PATCH 3/3] ahci_platform: add STRICT_AHCI platform type · Brian Norris <computersforpeace@gmail.com> · 2012-02-20
Re: [PATCH 0/3] ahci: fix boot/resume COMRESET failures · Jeff Garzik <hidden> · 2012-02-20

From: Tejun Heo <tj@kernel.org>
Date: 2012-02-20 20:51:26
Also in: lkml

Hello,

Overall the patchset looks good but

On Mon, Feb 20, 2012 at 12:09:21PM -0800, Brian Norris wrote:

+	AHCI_HFLAG_STRICT_SPEC		= (1 << 15), /* strict AHCI spec */

can you please use something more specific?  e.g. something like
SKIP_ENGINE_ON_PORT_START and then explain what the flag is about in
the comment?

Thanks.

-- 
tejun

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help