Hello.

On 18-01-2011 14:43, Zang Roy-R61911 wrote:

quoted

On 18-01-2011 6:01, Zang Roy-R61911 wrote:

quoted

quoted

quoted

In FSL sata v2 block, the snoop bit of PRDT Word3 description
information is at bit28 instead of bit22.

quoted

quoted

quoted

quoted

This patch adds FSL sata v2 probe and resolve this difference.

quoted

quoted

quoted

quoted

Signed-off-by: Xulei<redacted>

quoted

quoted

[snip]

quoted

quoted

quoted

quoted

diff --git a/arch/powerpc/boot/dts/p1022ds.dts

b/arch/powerpc/boot/dts/p1022ds.dts

quoted

index 2bbecbb..9ad41dd 100644

--- a/arch/powerpc/boot/dts/p1022ds.dts
+++ b/arch/powerpc/boot/dts/p1022ds.dts

@@ -475,14 +475,14 @@
    		};

    		sata@18000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
    			reg =<0x18000 0x1000>;
    			cell-index =<1>;
    			interrupts =<74 0x2>;
    		};

    		sata@19000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
    			reg =<0x19000 0x1000>;
    			cell-index =<2>;
    			interrupts =<41 0x2>;

quoted

quoted

quoted

      Please put this into the separate patch and push thru the PPC tree.

quoted

quoted

I agree to put to them to separate patches, but should we
pull in the separate patches to one candidate tree to make
the function work?

quoted

     I don't understand. What is "candidate tree"?

Powerpc or ide git repository for upstream to mainline.

    s/ide/libata/

It is odd that patches for one function in different trees.

    The libata tree doesn't need to be concerned with PPC board specific 
device trees. Although it's up to the maintainer... just cross post the patch, 
and let the corresponding maintainers fogure it out.

Thanks.
Roy

WBR, Sergei