Thread (10 messages) 10 messages, 6 authors, 2011-01-19

RE: [PATCH] ATA: Add FSL sata v2 controller support

From: Zang Roy-R61911 <hidden>
Date: 2011-01-18 11:43:49
Also in: linuxppc-dev

-----Original Message-----
From: Sergei Shtylyov [mailto:sshtylyov@mvista.com]
Sent: Tuesday, January 18, 2011 19:27 PM
To: Zang Roy-R61911
Cc: Sergei Shtylyov; Xu Lei-B33228; linuxppc-dev@lists.ozlabs.org; Gala Kumar-
B11780; jgarzik@pobox.com; linux-ide@vger.kernel.org
Subject: Re: [PATCH] ATA: Add FSL sata v2 controller support

Hello.

On 18-01-2011 6:01, Zang Roy-R61911 wrote:
quoted
quoted
quoted
In FSL sata v2 block, the snoop bit of PRDT Word3 description
information is at bit28 instead of bit22.
quoted
quoted
quoted
This patch adds FSL sata v2 probe and resolve this difference.
quoted
quoted
quoted
Signed-off-by: Xulei<redacted>
quoted
[snip]
quoted
quoted
quoted
diff --git a/arch/powerpc/boot/dts/p1022ds.dts
b/arch/powerpc/boot/dts/p1022ds.dts
quoted
index 2bbecbb..9ad41dd 100644
--- a/arch/powerpc/boot/dts/p1022ds.dts
+++ b/arch/powerpc/boot/dts/p1022ds.dts
@@ -475,14 +475,14 @@
   		};

   		sata@18000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
   			reg =<0x18000 0x1000>;
   			cell-index =<1>;
   			interrupts =<74 0x2>;
   		};

   		sata@19000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
   			reg =<0x19000 0x1000>;
   			cell-index =<2>;
   			interrupts =<41 0x2>;
quoted
quoted
     Please put this into the separate patch and push thru the PPC tree.
quoted
I agree to put to them to separate patches, but should we
pull in the separate patches to one candidate tree to make
the function work?
    I don't understand. What is "candidate tree"?
Powerpc or ide git repository for upstream to mainline.
It is odd that patches for one function in different trees.
Thanks.
Roy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help