-----Original Message-----
From: linuxppc-dev-bounces+poonam.aggrwal=freescale.com@lists.ozlabs.org
[mailto:linuxppc-dev-
bounces+poonam.aggrwal=freescale.com@lists.ozlabs.org] On Behalf Of
Sergei Shtylyov
Sent: Monday, January 17, 2011 5:18 PM
To: Xu Lei-B33228
Cc: jgarzik@pobox.com; Gala Kumar-B11780; linuxppc-dev@lists.ozlabs.org;
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ATA: Add FSL sata v2 controller support

Hello.

On 17-01-2011 10:10, Xulei wrote:

quoted

In FSL sata v2 block, the snoop bit of PRDT Word3 description
information is at bit28 instead of bit22.

quoted

This patch adds FSL sata v2 probe and resolve this difference.

quoted

Signed-off-by: Xulei <redacted>

    AFAIK, full name is required.

quoted

Signed-off-by: Roy Zang <redacted>

[...]

quoted

diff --git a/arch/powerpc/boot/dts/p1022ds.dts

b/arch/powerpc/boot/dts/p1022ds.dts
index 2bbecbb..9ad41dd 100644

--- a/arch/powerpc/boot/dts/p1022ds.dts
+++ b/arch/powerpc/boot/dts/p1022ds.dts

@@ -475,14 +475,14 @@
  		};

  		sata@18000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";

Can we fix this compatibity at run time by u-boot?

quoted

  			reg =<0x18000 0x1000>;
  			cell-index =<1>;
  			interrupts =<74 0x2>;
  		};

  		sata@19000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
  			reg =<0x19000 0x1000>;
  			cell-index =<2>;
  			interrupts =<41 0x2>;

    Please put this into the separate patch and push thru the PPC tree.

quoted

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index

b0214d0..a56399a 100644

--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c

[...]

quoted

@@ -417,7 +420,8 @@ static void sata_fsl_qc_prep(struct ata_queued_cmd

*qc)

  	if (qc->flags&  ATA_QCFLAG_DMAMAP)
  		num_prde = sata_fsl_fill_sg(qc, (void *)cd,
-					&ttl_dwords, cd_paddr);
+					&ttl_dwords, cd_paddr,
+					    host_priv->data_snoop);

    Please align these lines uniformly.

WBR, Sergei
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev