On Thu, Jul 07, 2005 at 12:09:00PM -0700, Christoph Lameter wrote:

On Thu, 7 Jul 2005, Linus Torvalds wrote:

quoted

Yes. Except that if hwif is NULL, we'll have other oopses since we access 
that in other places.

Why _is_ hwif NULL anyway? That's another, unrelated thing, and should 
probably have a separate check and an early return.

I was wondering about that one as well. Andi brought it up.

I don't know why hwif was NULL, but my kernel definitely crashed.
hwif was NULL in the first function (I first misread the oops
and thought it was pci_dev NULL, but it wasn't).  For the second
I didn't verify it was hwif or pci_dev NULL, but one of them
was too.

The setup was a Intel board with 1 PATA/4 SATA onboard and only a CD-ROM 
and a external Promise PATA controller with two PATA disks.

-Andi