On Wed, 6 Jul 2005 16:35:11 +0200
Bartlomiej Zolnierkiewicz [off-list ref] wrote:

On 7/6/05, Andi Kleen [off-list ref] wrote:

quoted

quoted

drive->hwif check is redundant, please remove it

It's not. My first version didn't have it but it still crashed.
It's what actually prevents the crash.
I also don't know why, but it's true.

very weird as HWIF(drive) == drive->hwif:

	ide_hwif_t *hwif = HWIF(drive);

...

	q = blk_init_queue_node(do_ide_request, &ide_lock,
				pcibus_to_node(drive->hwif->pci_dev->bus));

                                               ^^^^^^^^^^^^^^

I oops on that one. Maybe it takes the early return. 

	if (!q)
		return 1;

...

	if (!hwif->rqsize) {

you should OOPS here

I would appreciate if some form of this patch is merged asap because it breaks
booting on my test machines.

-Andi