Thread (24 messages) 24 messages, 5 authors, 2005-07-08

Re: [another PATCH] Fix crash on boot in kmalloc_node IDE changes

From: Linus Torvalds <torvalds@osdl.org>
Date: 2005-07-07 19:00:57
Also in: lkml


On Thu, 7 Jul 2005, Christoph Lameter wrote:
On Thu, 7 Jul 2005, Linus Torvalds wrote:
quoted
If you make it use a trivial inline function for the thing, I think that 
would be ok, though.
Like this?
Yes. Except that if hwif is NULL, we'll have other oopses since we access 
that in other places.

Why _is_ hwif NULL anyway? That's another, unrelated thing, and should 
probably have a separate check and an early return.

So there's two unrelated issues: hwif being NULL is a serious error
regardless of any node issues, and pci_dev being NULL just means we aren't
a PCI device.

Bartlomiej?

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help