Re: [PATCH] updates to Vitesse SATA driver
From: Dave <hidden>
Date: 2004-09-30 16:51:06
On Thu, 30 Sep 2004 09:17:09 -0700, Dave [off-list ref] wrote:
On Wed, 29 Sep 2004 23:28:19 -0400, Jeff Garzik <jgarzik@pobox.com > wrote:quoted
Technically speaking, one sets the ATA_FLAG_SLAVE_POSS flag to tell the libata core to scan for device 1.For some odd reason we are scanning device 1 on XScale IOP platform with the exact same driver code. I'll have to investigate some more and see why it's doing that.
Okay, I must be not seeing something obvious. The ATA_FLAG_SLAVE_POSS flag is not set. But I only see it being checked during reset. When ata_bus_probe is called, it probes for ATA_MAX_DEVICES, which is both dev 0 and dev 1. Thus dev 1 fails of course, and the core changes the ctl without the sata driver knowing and causes interrupt mask to remain set..... -- -= Dave =- Software Engineer - Advanced Development Engineering Team Storage Component Division - Intel Corp. mailto://dave.jiang @ intel ---- The views expressed in this email are mine alone and do not necessarily reflect the views of my employer (Intel Corp.).