Re: [PATCH v2 1/9] i2c: i801: Improve disabling runtime pm
From: Wolfram Sang <wsa@kernel.org>
Date: 2021-08-17 20:17:05
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Wolfram Sang <wsa@kernel.org>
Date: 2021-08-17 20:17:05
quoted
quoted
I dunno if it's being discussed, but with this you effectively allow user to override the setting. It may screw things up AFAIU the comment above.No, this hasn't been discussed. At least not now. Thanks for the hint. This attribute is writable for the root user, so we could argue that the root user has several options to break the system anyway.But it will mean the side effect on this driver and typical (root-run) system application (systemd like?) should care now the knowledge about this side-effect. I do not think it is desired behaviour. But I'm not a maintainer and I commented here just to make everybody understand the consequences of the change.
Jean, are you still fine with this patch then?