Re: [PATCH v2 1/9] i2c: i801: Improve disabling runtime pm
From: Andy Shevchenko <hidden>
Date: 2021-08-11 15:41:49
From: Andy Shevchenko <hidden>
Date: 2021-08-11 15:41:49
On Fri, Aug 06, 2021 at 11:12:18PM +0200, Heiner Kallweit wrote:
Setting the autosuspend delay to a negative value disables runtime pm in a little bit smarter way, because we need no cleanup when removing the driver. Note that this is safe when reloading the driver, because the call to pm_runtime_set_autosuspend_delay() in probe() will reverse the effect. See update_autosuspend() for details.
...
* BIOS is accessing the host controller so prevent it from * suspending automatically from now on. */ - pm_runtime_get_sync(&pdev->dev); + pm_runtime_set_autosuspend_delay(&pdev->dev, -1);
I dunno if it's being discussed, but with this you effectively allow user to override the setting. It may screw things up AFAIU the comment above. -- With Best Regards, Andy Shevchenko