Re: [PATCH v2 2/9] i2c: i801: make p2sb_spinlock a mutex
From: Wolfram Sang <wsa@kernel.org>
Date: 2021-08-10 20:38:51
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Wolfram Sang <wsa@kernel.org>
Date: 2021-08-10 20:38:51
On Fri, Aug 06, 2021 at 11:13:29PM +0200, Heiner Kallweit wrote:
p2sb_spinlock is used in i801_add_tco_spt() only, and in process context only. Therefore a mutex is sufficient, and we can make the definition local to i801_add_tco_spt(). Reviewed-by: Jean Delvare <redacted> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-next, thanks!
#include <linux/platform_device.h> #include <linux/platform_data/itco_wdt.h> #include <linux/pm_runtime.h> +#include <linux/mutex.h>
Can you also sort the includes while cleaning up the driver? Then, it is more obvious that mutex.h was already needed for acpi_lock. That would be great!