Re: [PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set
From: Andy Shevchenko <hidden>
Date: 2021-03-31 14:11:51
Also in:
lkml
From: Andy Shevchenko <hidden>
Date: 2021-03-31 14:11:51
Also in:
lkml
On Wed, Mar 31, 2021 at 4:24 PM Matthias Schiffer [off-list ref] wrote:
On Wed, 2021-03-31 at 15:35 +0300, Andy Shevchenko wrote:quoted
On Wed, Mar 31, 2021 at 2:39 PM Matthias Schiffer [off-list ref] wrote:
...
quoted
quoted
+ tqmx_gpio_resources[0].flags = 0;Please set IORESOURCE_DISABLED flag in the initial structure instead.Is there any documentation for the correct usage of this flag? I think I tried IORESOURCE_DISABLED originally, but it didn't have any effect (platform_get_irq() ignored the flag and returned the resource anyways). I might misremember though, I originally wrote the series some time ago.
It seems this flag is used solely for ACPI / PNP resources... Hmm... I dunno how platorm_get_irq*() should respect this flag. You see, that in the ACPI branch it has been checked there. -- With Best Regards, Andy Shevchenko