Thread (20 messages) 20 messages, 3 authors, 2021-06-27
STALE1803d

[PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set

From: Matthias Schiffer <hidden>
Date: 2021-03-31 11:37:02
Also in: lkml
Subsystem: multifunction devices (mfd), the rest, tq systems board & driver support · Maintainers: Lee Jones, Linus Torvalds

The driver was registering IRQ 0 when no IRQ was set. This leads to
warnings with newer kernels.

Clear the resource flags, so no resource is registered at all in this
case.

Signed-off-by: Matthias Schiffer <redacted>
---
 drivers/mfd/tqmx86.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c
index ddddf08b6a4c..732013f40e4e 100644
--- a/drivers/mfd/tqmx86.c
+++ b/drivers/mfd/tqmx86.c
@@ -209,6 +209,8 @@ static int tqmx86_probe(struct platform_device *pdev)
 
 		/* Assumes the IRQ resource is first. */
 		tqmx_gpio_resources[0].start = gpio_irq;
+	} else {
+		tqmx_gpio_resources[0].flags = 0;
 	}
 
 	ocores_platfom_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id);
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help