Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M
From: Andy Shevchenko <hidden>
Date: 2021-03-31 12:38:26
Also in:
lkml
On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer [off-list ref] wrote:
All future TQMx86 SoMs will use a 24MHz LPC clock, so we can use that as a default instead of listing each new module individually.
...
quoted hunk ↗ jump to hunk
case TQMX86_REG_BOARD_ID_90UC: return "TQMx90UC"; + case TQMX86_REG_BOARD_ID_E40M: + return "TQMxE40M"; default: return "Unknown"; }@@ -138,12 +141,6 @@ static const char *tqmx86_board_id_to_name(u8 board_id) static int tqmx86_board_id_to_clk_rate(u8 board_id) { switch (board_id) { - case TQMX86_REG_BOARD_ID_50UC: - case TQMX86_REG_BOARD_ID_60EB: - case TQMX86_REG_BOARD_ID_70EB: - case TQMX86_REG_BOARD_ID_80UC: - case TQMX86_REG_BOARD_ID_90UC: - return 24000; case TQMX86_REG_BOARD_ID_E39M: case TQMX86_REG_BOARD_ID_E39C: case TQMX86_REG_BOARD_ID_E39x:@@ -152,7 +149,7 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id) case TQMX86_REG_BOARD_ID_E38C: return 33000; default: - return 0; + return 24000;
AFAICS it will return 24 MHz for "Unknown" board. Is it okay to be so brave? -- With Best Regards, Andy Shevchenko