Re: [PATCH v1 2/3] i2c: i801: Drop duplicate NULL check in i801_del_mux()
From: Jean Delvare <hidden>
Date: 2021-01-06 16:04:01
Also in:
linux-i2c
On Mon, 28 Dec 2020 22:06:17 +0200, Andy Shevchenko wrote:
quoted hunk ↗ jump to hunk
Since gpiod_remove_lookup_table() is NULL-aware, no need to have this check in the caller. Drop duplicate NULL check. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/busses/i2c-i801.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index ae90713443fa..7c2569a18f8c 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c@@ -1487,8 +1487,7 @@ static void i801_del_mux(struct i801_priv *priv) { if (priv->mux_pdev) platform_device_unregister(priv->mux_pdev); - if (priv->lookup) - gpiod_remove_lookup_table(priv->lookup); + gpiod_remove_lookup_table(priv->lookup); } static unsigned int i801_get_adapter_class(struct i801_priv *priv)
Reviewed-by: Jean Delvare <redacted> -- Jean Delvare SUSE L3 Support