Re: [PATCH v1 1/3] gpiolib: Follow usual pattern for gpiod_remove_lookup_table() call
From: Jean Delvare <hidden>
Date: 2021-01-06 16:04:01
Also in:
linux-i2c
From: Jean Delvare <hidden>
Date: 2021-01-06 16:04:01
Also in:
linux-i2c
On Mon, 28 Dec 2020 22:06:16 +0200, Andy Shevchenko wrote:
The usual pattern for the remove calls, like gpiod_remove_lookup_table(), is to be NULL-aware, i.o.w. become a no-op whenever parameter is NULL. Update gpiod_remove_lookup_table() call to follow this pattern. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index b02cc2abd3b6..611d6ea82d75 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c@@ -3460,6 +3460,10 @@ EXPORT_SYMBOL_GPL(gpiod_add_lookup_table); */ void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) { + /* Nothing to remove */ + if (!table) + return; + mutex_lock(&gpio_lookup_lock); list_del(&table->list);
Reviewed-by: Jean Delvare <redacted> -- Jean Delvare SUSE L3 Support