Thread (37 messages) 37 messages, 3 authors, 20d ago

Re: [PATCH v4 04/14] mfd: lm3533: Pass only regmap and light sensor presence to child devices

From: Svyatoslav Ryhel <hidden>
Date: 2026-06-10 14:34:40
Also in: dri-devel, linux-devicetree, linux-iio, linux-leds, lkml

вт, 9 черв. 2026 р. о 22:06 Andy Shevchenko [off-list ref] пише:
On Sat, Jun 06, 2026 at 07:57:28AM +0300, Svyatoslav Ryhel wrote:
quoted
Instead of passing the entire lm3533 core data structure, only pass the
regmap and the light sensor presence flag to child devices.
...
quoted
 struct lm3533_als {
-     struct lm3533 *lm3533;
+     struct regmap *regmap;
      struct platform_device *pdev;
And this pdev is probably not needed. But I haven't checked the whole lot of
the patches yet.
It is needed since it holds childs pdev (dev would be better, but not
in this patchset), you cannot get childs dev from regmap since regmap
holds cores dev.
quoted
      unsigned long flags;
...
quoted
 struct lm3533_ctrlbank {
-     struct lm3533 *lm3533;
+     struct regmap *regmap;
      struct device *dev;
Ditto.
Same here, dev holds either LEDs dev or backlight dev.
quoted
      int id;
 };
--
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help