On Sat, Jun 06, 2026 at 07:57:31AM +0300, Svyatoslav Ryhel wrote:

Switch from sysfs_create_group() to device_add_group() including device
managed where appropriate.

This should use .dev_groups member of struct device_driver.

...

+	ret = devm_device_add_group(&bd->dev, &lm3533_bl_attribute_group);

This will make Greg KH very grumpy. (For the record, original code as well
but it already is in upstream. So, thanks for trying to address this, just
needs a bit more of work.)

+	if (ret < 0)
+		return dev_err_probe(&pdev->dev, ret,
+				     "failed to create sysfs attributes\n");

-- 
With Best Regards,
Andy Shevchenko