Thread (6 messages) 6 messages, 3 authors, 2024-08-01

Re: [PATCH] backlight: pwm_bl: print errno for probe errors

flat view

From: Uwe Kleine-König <hidden>
Date: 2024-08-01 09:26:26
Also in: dri-devel, linux-pwm, lkml

Hello Martin,

On Thu, Aug 01, 2024 at 11:12:55AM +0200, Martin Kepplinger-Novaković wrote:
quoted hunk ↗ jump to hunk
This makes debugging often easier.

Signed-off-by: Martin Kepplinger-Novaković <redacted>
---
 drivers/video/backlight/pwm_bl.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index f1005bd0c41e3..cc7e7af71891f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 						  GPIOD_ASIS);
 	if (IS_ERR(pb->enable_gpio)) {
 		ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->enable_gpio),
-				    "failed to acquire enable GPIO\n");
+				    "failed to acquire enable GPIO: %ld\n",
+				    PTR_ERR(pb->enable_gpio));
AFAIK dev_err_probe already emits the error code passed as 2nd
parameter. So I wonder about this patch's benefit.

Best regards
Uwe

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help