Thread (6 messages) 6 messages, 3 authors, 2024-08-01

[PATCH] backlight: pwm_bl: print errno for probe errors

STALE796d

From: Martin Kepplinger-Novaković <hidden>
Date: 2024-08-01 09:16:03
Also in: dri-devel, linux-pwm, lkml
Subsystem: backlight class/subsystem, framebuffer layer, the rest · Maintainers: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Linus Torvalds 

This makes debugging often easier.

Signed-off-by: Martin Kepplinger-Novaković <redacted>
---
 drivers/video/backlight/pwm_bl.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index f1005bd0c41e3..cc7e7af71891f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 						  GPIOD_ASIS);
 	if (IS_ERR(pb->enable_gpio)) {
 		ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->enable_gpio),
-				    "failed to acquire enable GPIO\n");
+				    "failed to acquire enable GPIO: %ld\n",
+				    PTR_ERR(pb->enable_gpio));
 		goto err_alloc;
 	}
 
@@ -513,7 +514,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 			pb->power_supply = NULL;
 		} else {
 			dev_err_probe(&pdev->dev, ret,
-				      "failed to acquire power regulator\n");
+				      "failed to acquire power regulator: %d\n",
+				      ret);
 			goto err_alloc;
 		}
 	}
@@ -521,7 +523,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 	pb->pwm = devm_pwm_get(&pdev->dev, NULL);
 	if (IS_ERR(pb->pwm)) {
 		ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->pwm),
-				    "unable to request PWM\n");
+				    "unable to request PWM: %ld\n",
+				    PTR_ERR(pb->pwm));
 		goto err_alloc;
 	}
 
-- 
2.39.2

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help